Repository navigation
Conversation
|
Picking this up for QA. |
QA Result: PASS
PR, 2 failures: Master, 1 failure: On
Limits:
Summary: With this bump, kairos-init retries a failed package command for real: one or two mirror failures in a row no longer fail the build, three still do. Master fails the build on the first failure. |
itxaka-agent
left a comment
There was a problem hiding this comment.
Automated triage agent (
kairos-triage-agent) running as@itxaka-agent.
This comment was generated by software. A human maintainer can override
any action taken here.
Approving. This is a pure dependency bump: go.mod moves yip to v1.26.5-0.20261027073353-b1c67bef913c, which is the mudler/yip#350 merge commit (b1c67bef913c, committed 2026-10-27 07:33:53Z, matching the pseudo-version timestamp). go.sum swaps the yip sums and drops stale entries. No code changes, CI is green apart from qa-gate, which waits on the QA label.
Note it also pulls in yip#345, #339 and #340. Renovate can move it to a tag once one is cut.
99d6c2e to
35b93fc
Compare
9ef1207 to
182efb4
Compare
182efb4 to
c8b7e51
Compare
itxaka-agent
left a comment
There was a problem hiding this comment.
Automated triage agent (
kairos-triage-agent) running as@itxaka-agent.
This comment was generated by software. A human maintainer can override
any action taken here.
Approving at c8b7e51. The diff is only the yip bump in go.mod and go.sum. The pseudo-version points at the mudler/yip#350 merge (b1c67bef913c), and the go.sum hashes match the Go checksum database. CI is green.
e4f0e43 to
8b92a69
Compare
c700ce7 to
7fa8bcd
Compare
Bump github.com/mudler/yip to b1c67bef913c, the merge of mudler/yip#350. The packages plugin now runs each refresh, upgrade, install and remove command up to three times, waiting 5 and 15 seconds, instead of failing the whole kairos-init stage on one mirror that is mid-sync. yip has no tag with that commit yet, so this is a pseudo-version. Renovate moves it to the next tag. go mod tidy also drops stale sums. Part of kairos-io#5560 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ettore Di Giacinto <mudler@kairos.io>
7fa8bcd to
48f6151
Compare
|
Superseded by d9a5c75 (#6122), which bumps yip to v1.27.0 and already contains the package manager retry from mudler/yip#350. |
Part of #5560
Summary
The
masterworkflow is red on fa68014 (run https://github.com/kairos-io/kairos/actions/runs/42849163678), and the cause is not the commit. A distro mirror was mid-sync while kairos-init ran its package step, and that step runs each package manager command once:The
build-flavors / ubuntu:20.04 (amd64)job of the same run installed the same package set without error. This is a flake that keeps coming back. Package mirror failures in kairos-init failedmaster5 times across 4 runs in the last 50 commits:ubuntu-pro-clientunmet dependencyperl-base_5.38.2-3.2ubuntu0.7_amd64.deb 404 Not Foundperl-base_5.34.0-3ubuntu1.10 404repomd.xml parser error ... Document is emptyrepomd.xmlerrormudler/yip#350 (merged 2026-10-27) adds the retry: the packages plugin runs each refresh, upgrade, install and remove command up to three times, waiting 5 and 15 seconds in between. No yip tag contains it yet (latest is v1.26.4), so kairos still runs the old code. The logs confirm this: the failing
apt-get installran once.What changed
go.mod:github.com/mudler/yipv1.26.4 ->v1.26.5-0.20261027073353-b1c67bef913c(the 🤖 Add signoff to autobump workflow #350 merge). It also brings the 3 other fixes merged on yipmainsince v1.26.4 (Add entangle support to discovery #345, 📖 Update raspberry.md #339, 📖 Update contributing icons #340). Renovate moves it to the next tag.go.sum: the new yip sums, plus stale entries thatgo mod tidyremoves.Limits
repomd.xmlcases.apt-get installagain without a newapt-get update.How it was tested
CGO_ENABLED=0 go build ./...passes.make kairos-init-embed-stubs,go test ./kairos-init/... ./sdk/...passes.runPackageCommandwithpackageAttempts = 3is in the module that Go resolves.AI disclosure: the ci-doctor bot (Claude) diagnosed this, wrote the change and opened this PR. No human read the code before it was opened.
🤖 Generated with Claude Code