Repository navigation
docs(operator): describe which files a NodeOpUpgrade installs - #794
Draft
jimmykarily wants to merge 3 commits into
Draft
jimmykarily wants to merge 3 commits into
jimmykarily wants to merge 3 commits into
Conversation
The NodeOpUpgrade page said the operator always passes --exclude-path for /etc/hostname and /etc/hosts, and that excludePaths "preserves" host paths. With kairos-io/kairos-operator#314 the upgrade copies from a plain bind mount of the upgrade Pod's root, so the node gets the image's own /etc/resolv.conf, /etc/hosts and /etc/hostname and the operator adds no exclusions of its own. excludePaths was also described wrongly before that change: kairos-agent builds the new system image from scratch, so an excluded path is missing from the new system rather than kept from the node. The section now says so and points to the persistent paths for data that must survive an upgrade. The subsection about overwriting /etc/hostname through a manual NodeOp is gone, since a NodeOpUpgrade now installs the image's /etc/hostname. Only the unreleased docs change. The versioned pages describe the released operators, which still behave the old way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
When the upgrade image has no /etc/resolv.conf, /etc/hosts or /etc/hostname, the container runtime creates an empty file there to mount the Pod's copy onto. kairos-io/kairos-operator#314 leaves any of the three that is missing or empty out of the new system, so the node matches a fresh install of the image. For /etc/resolv.conf that keeps images that rely on systemd to create the symlink at boot working. The page now explains this, shows the resulting --exclude-path in the example command, and says the kairos-agent v3.6.0 requirement also applies when the image lacks one of the files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
kairos-io/kairos-operator#314 only leaves /etc/resolv.conf, /etc/hosts and /etc/hostname out of the new system when they are missing or empty regular files. A symlink is copied as is, so an image that ships /etc/resolv.conf as a link to systemd-resolved's file keeps it. The page said "missing or empty", which reads as if an empty or dangling link target would also exclude the link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for kairos-io/kairos-operator#314, which fixes kairos-io/kairos#6109. Merge after that PR, since this page describes the operator's unreleased behaviour.
What changes for readers
The NodeOpUpgrade page currently says:
--exclude-path /etc/hostname --exclude-path /etc/hoststokairos-agent upgrade;spec.excludePaths"preserves" host paths during the upgrade;/etc/hostnameyou need a manual NodeOp with an OCI source.After kairos-io/kairos-operator#314, a NodeOpUpgrade copies the new system from a plain (non-recursive) bind mount of the upgrade Pod's root. The node gets the image's own
/etc/resolv.conf,/etc/hostsand/etc/hostname, without the Pod-specific copies Kubernetes mounts into every Pod. The only exclusions the operator adds are for those of the three files the image does not ship, or ships empty.The "preserves" wording was also wrong before that change.
kairos-agentbuilds the new system image from scratch, so an excluded path is missing from the new system; the node's current copy is not kept.Edits
Only
operator-docs/nodeop-upgrade.md. The versioned pages describe released operators, which still behave the old way.excludePathstable row and the example comment drop the always-excluded pair and describe what an exclusion does.spec.image.excludePathsand points to/usr/localand the persistent bind-mounted paths for data that must survive an upgrade.spec.imagelacks one of the three files, the container runtime creates an empty one to mount onto, and the upgrade leaves any of them that is missing or empty out of the new system. The example command shows the resulting--exclude-path.excludePathsis set or when the image lacks one of the three files./etc/hostname.I did not build the site locally. No other page links to the removed anchors (
#preserving-host-paths-from-the-upgrade,#overwriting-etchostname-on-purpose) outside the versioned docs, which keep their own copies of those sections.🤖 Generated with Claude Code