Repository navigation
Specialize mutability on the operation - #379
Merged
Merged
Conversation
`op` is only passed to `promote_operation` so Julia did not specialize on it and compiled `promote_operation(::Function, ...)` with a runtime dispatch. Any new `promote_operation` method with generic argument types then invalidated it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
=======================================
Coverage ? 92.04%
=======================================
Files ? 23
Lines ? 2375
Branches ? 0
=======================================
Hits ? 2186
Misses ? 189
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
blegat
force-pushed
the
bl/mutability_specialize
branch
from
October 23, 2026 19:13
7224bf6 to
dccca54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opis only passed topromote_operationso Julia did not specialize on it and compiledpromote_operation(::Function, ...)with a runtime dispatch. Any newpromote_operationmethod with generic argument types then invalidated it.This removes the need for JuliaAlgebra/StarAlgebras.jl#144 which showed we would get many of these so we needed to find the root of the issue which this PR fixes.