Skip to content

Fix HTTP 416 making files an exact multiple of 10 MiB permanently unreadable #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giggio wants to merge 1 commit into from
Closed

Fix HTTP 416 making files an exact multiple of 10 MiB permanently unreadable #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fs/graph/drive_item.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,11 @@ func GetItemContentStream(id string, auth *Auth, output io.Writer) (uint64, erro

// multipart download
var n uint64
for i := 0; i < int(item.Size/downloadChunkSize)+1; i++ {
// The trip count must be ceil(size/chunk). floor(size/chunk)+1 agrees with
// that for every size except an exact multiple of the chunk size, where it is
// one too many and the final request asks for a range starting at EOF - which
// the API answers with 416, making the item permanently unreadable.
for i := 0; i < int((item.Size+downloadChunkSize-1)/downloadChunkSize); i++ {
start := i * downloadChunkSize
end := start + downloadChunkSize - 1
log.Info().
Expand Down