Repository navigation
Fix tab expansion for tab sizes greater than eight - #1457
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string_expand()expands tabs by copying from an eight-space string. Withtab-size = 9, this can copy the terminating NUL and truncate displayed text; larger tab sizes read past the literal (reproduced with AddressSanitizer at 16 and 32).Fill the already bounded destination range with
memset()and add a regression test for tab sizes 8, 9, 16 and 32. The test checks exact spacing for leading, consecutive and aligned tabs.Validation:
git diff --checkpassed.