Repository navigation
Fix interval text encoding of math.MinInt64 microseconds - #2689
Merged
jackc merged 1 commit intoOct 17, 2026
Merged
Conversation
Negating math.MinInt64 overflows, so the text encoder wrote "--2562047788:00:-54.-775808" for it. PostgreSQL prints that value as -2562047788:00:54.775808. Take the magnitude as a uint64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding an
IntervalwithMicrosecondsofmath.MinInt64to text gave--2562047788:00:-54.-775808, which does not scan back.absMicroseconds = -absMicrosecondsoverflows for that one value.PostgreSQL can return it:
'-2562047788:00:54.775807'::interval - '1 microsecond'::intervalprints-2562047788:00:54.775808, and'-infinity'::intervalon 17+ carries the same microseconds field. The text encoder is whatInterval.ValueandDecodeDatabaseSQLValue(binary results) go through.The magnitude is now a
uint64, so it cannot overflow. I added a row toTestIntervalTextEncode. I also ran the encoder against PostgreSQL 18: the new output matches PostgreSQL's own text and scans back to the sameInterval.This is separate from #2065 (interval infinity), which rewrites the same function.