Repository navigation
Conversation
Route exceptions from *ValueChanged and *TargetConnected/Disconnected (and outlet callbacks) through Application#handleError so they match the documented connect/disconnect/action behavior. Fixes hotwired#711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context#invokeControllerMethodso target/outlet lifecycle callbacks report viahandleErrorinstead of escaping uncaught.*ValueChangedexceptions throughhandleError(keeping the existing TypeError message enrichment).Fixes #711
Test plan
yarn build:test && yarn karma start karma.conf.cjs --browsers=ChromeHeadless(219 SUCCESS)fooValueChanged/itemTargetConnectedlogs via Stimulus error handling and still allows the rest of the app to continue