Repository navigation
Define public names of the humidifier integration - #186622
Merged
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The export list preserves supported imports, the wildcard-import change is documented, and no blocking issues remain.
0 open findings
What changed in this PR
Defines the humidifier platform’s public API explicitly, consistent with other entity platforms.
Changes:
- Adds
__all__for supported public names, including both state constants. - Removes redundant unused-import suppressions.
| File | Description |
|---|---|
homeassistant/components/humidifier/__init__.py |
Declares public exports and imports STATE_OFF. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
balloob
approved these changes
Oct 15, 2026
28 of 48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
For developers only: as the humidifier integration now defines
__all__,from homeassistant.components.humidifier import *only imports the names listed in it, instead of every public name of the module. No such wildcard import was found in core or in the custom integrations of the HACS default repositories. Explicit imports are not affected.Proposed change
Define the public names of the humidifier integration with
__all__, as already done by sensor, cover, select, number and other entity platforms.This came up with @joostlek during refactoring: why the
# noqa: F401markers were needed on the package root imports, and whether they could be removed. Listing the public names in__all__states that intent explicitly, so the markers are no longer needed.As humidifiers have no dedicated state enum,
STATE_ONandSTATE_OFFare exported as the humidifier states, in the same way as other platforms export their*Stateenum.It was checked against:
homeassistant.components.humidifierby other integrations is included. Withno_implicit_reexporttemporarily enabled for the humidifier integration (it is currently disabled forhomeassistant.components.*), mypy reports no re-export issue on the 30 core modules importing from it;Enforcing this with mypy (
no_implicit_reexportfor the entity platforms) will follow once all of them define__all__. No functional change.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: