Skip to content

search tag normalization fix #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacper-kozera merged 1 commit into from
Oct 27, 2026
Merged

search tag normalization fix #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...aksha-app-service/src/jvmMain/java/com/here/naksha/app/service/http/ops/TagQueryUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import static com.here.naksha.lib.core.models.payload.events.QueryDelimiter.COMMA;
import static com.here.naksha.lib.core.models.payload.events.QueryDelimiter.END;
import static com.here.naksha.lib.core.models.payload.events.QueryDelimiter.PLUS;
import static naksha.model.TagNormalizer.normalizeTag;

import com.here.naksha.lib.core.models.payload.events.QueryDelimiter;
import com.here.naksha.lib.core.models.payload.events.QueryParameter;
Expand Down Expand Up @@ -159,6 +158,6 @@ private static ITagQuery processAndSubQuery(
}

private static TagExists tagExists(String tag) {
return new TagExists(normalizeTag(tag));
return new TagExists(tag);
}
}
17 changes: 17 additions & 0 deletions ...service/src/jvmTest/java/com/here/naksha/app/service/util/ParamsToQueryConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,23 @@ void assertionFailWhenTryingToBuildOperationWithSurroundingDelimiters() {
private static Stream<Arguments> simpleTagsSample() {
return Stream.of(
tagQuerySpec("tags=x", tq -> assertTagExistsWithName(tq, "x"), "only 'x'"),
tagQuerySpec("tags=One", tq -> assertTagExistsWithName(tq, "One"), "preserve capitalized tag"),
tagQuerySpec(
"tags=One+Two",
tq -> {
TagAnd tagAnd = assertTagAnd(tq);
assertTagExistsWithName(tagAnd.get(0), "One");
assertTagExistsWithName(tagAnd.get(1), "Two");
},
"preserve capitalized tags in AND search"),
tagQuerySpec(
"tags=One,Two",
tq -> {
TagOr tagOr = assertTagOr(tq);
assertTagExistsWithName(tagOr.get(0), "One");
assertTagExistsWithName(tagOr.get(1), "Two");
},
"preserve capitalized tags in OR search"),
tagQuerySpec(
"tags=this,that",
tq -> {
Expand Down
Loading