Repository navigation
Compute authenticatable_name once per strategy class - #5872
Open
sampokuokkanen wants to merge 1 commit into
Open
sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
Warden instantiates strategies on every request, so the per-instance @authenticatable_name memo never hits: every request that runs the strategies' valid? (any request with no user in the session that calls authenticate/current_user) splits, underscores and subs the class name again for each strategy. Cache it on the strategy class instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warden instantiates strategies on every request, so the per-instance @authenticatable_name memo never hits: every request that runs the strategies' valid? (any request with no user in the session that calls authenticate/current_user) splits, underscores and subs the class name again for each strategy. Cache it on the strategy class instead.