Repository navigation
Conversation
behdad
force-pushed
the
skera-review-radial-sentinels
branch
from
October 12, 2026 23:18
96a857b to
3202282
Compare
behdad
force-pushed
the
skera-review-radial-sentinels
branch
from
October 14, 2026 23:11
3202282 to
80329a5
Compare
Propagate reviewed fixes and repaired ancestry through #2340. Assisted-by: OpenAI Codex
This tree is unchanged; the replacement evaluator already handles missing variation rows. Preserve the repaired parent ancestry. Assisted-by: OpenAI Codex
Preserve reviewed parent ancestry and each PR's existing feature changes. Assisted-by: OpenAI Codex
Preserve the independently validated TrueType changes and all feature code. Assisted-by: OpenAI Codex
Keep empty record counts and allocation bounds at each PR boundary. Assisted-by: OpenAI Codex
Move the existing #2338 correction into the width-reduction PR. Assisted-by: OpenAI Codex
Reject unsupported versions and oversized arrays before ownership. Keep current HarfBuzz references with complete feature parameters. Assisted-by: OpenAI Codex
Preserve zero float32 products and reject subnormal condition pinning. Assisted-by: OpenAI Codex
Bound pairwise work after deduplication, avoid temporary pair vectors, and keep the corrected HarfBuzz column order at introduction. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial instancing of a VarRadialGradient failed when its explicit map contained only NO_VARIATION_INDEX entries and its item variation store was absent. The radial constancy check required a store before resolving the sentinel mappings.
Resolve each mapping first and build a store plan only for live indices. The regression constructs a valid COLRv1/CPAL font, partially instances it, and checks that both radii and stop offsets survive.
Validation: the targeted partial-instancing regression passed. The analogous HarfBuzz table-dropping bug is fixed in harfbuzz/harfbuzz#6389; FontTools passes this case, including its pending COLR instancing PR.
Found while auditing the COLR follow-up #2316.
Depends on #2339.
Validation of the combined fixes: 1,199 Skera, Skrifa and write-fonts tests passed with Rust 1.89 and the Skera CLI enabled; 8 existing tests were ignored. Clippy with all targets/features, formatting and diff checks passed.