Repository navigation
Conversation
behdad
force-pushed
the
skera-cli-glyph-map-order
branch
from
October 10, 2026 18:08
0525f65 to
b5c2bf8
Compare
This was referenced Oct 11, 2026
behdad
force-pushed
the
skera-cli-glyph-map-order
branch
from
October 12, 2026 03:19
b5c2bf8 to
ffcec93
Compare
behdad
force-pushed
the
skera-cli-glyph-map-order
branch
2 times, most recently
from
October 12, 2026 20:53
50696b9 to
6a6f3f8
Compare
behdad
force-pushed
the
skera-cli-glyph-map-order
branch
from
October 12, 2026 22:04
6a6f3f8 to
fc221bf
Compare
behdad
force-pushed
the
skera-cli-glyph-map-order
branch
from
October 14, 2026 23:11
fc221bf to
cab970c
Compare
Propagate reviewed fixes and repaired ancestry through #2314. Assisted-by: OpenAI Codex
This tree is unchanged; the replacement evaluator already handles missing variation rows. Preserve the repaired parent ancestry. Assisted-by: OpenAI Codex
Preserve reviewed parent ancestry and each PR's existing feature changes. Assisted-by: OpenAI Codex
Preserve the independently validated TrueType changes and all feature code. Assisted-by: OpenAI Codex
Keep empty record counts and allocation bounds at each PR boundary. Assisted-by: OpenAI Codex
Move the existing #2338 correction into the width-reduction PR. Assisted-by: OpenAI Codex
Reject unsupported versions and oversized arrays before ownership. Keep current HarfBuzz references with complete feature parameters. Assisted-by: OpenAI Codex
Preserve zero float32 products and reject subnormal condition pinning. Assisted-by: OpenAI Codex
Bound pairwise work after deduplication, avoid temporary pair vectors, and keep the corrected HarfBuzz column order at introduction. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--gid-map=1:5 --gids=2previously included glyph 1 again after parsing all selectors, producing a larger subset than HarfBuzz. Apply each mapping's glyph inclusion at its command-line position so later replacements/removals take effect.Allow repeated mappings, accumulating pairs with the last request for each original glyph taking precedence. Mapping lists also accept whitespace separators and trailing separators like HarfBuzz. The existing monotone-order validation still applies to the final retained mapping.
Validation: 12 CLI selection tests, glyph-mapping, keep-everything, and VARC integration tests, all-feature Clippy, rustfmt, and the CI typos version pass. Regressions cover replacements/removals after maps, repeated maps and aliases, whitespace, empty additions, preset resets, and selector files.
Final validation: 424 tests pass with all features, 409 pass without default features, and the 8 slow/repacker tests pass. A 522-case comparison against current HarfBuzz found no glyph, metric, outline, name, axis, or shaping discrepancies in these CLI selections.
Stacked on #2313.
Readers use read-fonts directly. write-fonts handles font assembly and owned table rebuilding; Skera retains its direct serializers and repacker. There is no separate generated Skera table tree.