Repository navigation
Conversation
behdad
force-pushed
the
skera-cff-identity-charset
branch
from
October 10, 2026 18:08
948f51f to
286c0da
Compare
behdad
force-pushed
the
skera-cff-identity-charset
branch
from
October 12, 2026 03:19
286c0da to
376374b
Compare
behdad
force-pushed
the
skera-cff-identity-charset
branch
from
October 12, 2026 20:41
376374b to
63cc1f2
Compare
behdad
force-pushed
the
skera-cff-identity-charset
branch
2 times, most recently
from
October 12, 2026 22:04
b00e32c to
aa4f61e
Compare
behdad
force-pushed
the
skera-cff-identity-charset
branch
from
October 14, 2026 23:11
aa4f61e to
ebdf70c
Compare
Propagate reviewed fixes and repaired ancestry through #2285. Assisted-by: OpenAI Codex
This tree is unchanged; the replacement evaluator already handles missing variation rows. Preserve the repaired parent ancestry. Assisted-by: OpenAI Codex
Preserve reviewed parent ancestry and each PR's existing feature changes. Assisted-by: OpenAI Codex
Preserve the independently validated TrueType changes and all feature code. Assisted-by: OpenAI Codex
Keep empty record counts and allocation bounds at each PR boundary. Assisted-by: OpenAI Codex
Move the existing #2338 correction into the width-reduction PR. Assisted-by: OpenAI Codex
Reject unsupported versions and oversized arrays before ownership. Keep current HarfBuzz references with complete feature parameters. Assisted-by: OpenAI Codex
Preserve zero float32 products and reject subnormal condition pinning. Assisted-by: OpenAI Codex
Bound pairwise work after deduplication, avoid temporary pair vectors, and keep the corrected HarfBuzz column order at introduction. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SUBSET_FLAGS_CFF_IDENTITY_CHARSETand--cff-identity-charset. CID-keyed CFF subsets emit CIDs equal to their output glyph IDs, following HarfBuzz's flag semantics, including retained-GID holes.The focused integration test checks CIDs, charstrings, font-dictionary selection, mappings, and metrics for renumbered and retained IDs; name-keyed CFF and CFF2 keep their existing output. Six fresh HB comparisons have no outline or width differences. Clippy, formatting, and the exact CI typo check pass.
Readers use read-fonts directly. write-fonts handles font assembly and owned table rebuilding; Skera retains its direct serializers and repacker. There is no separate generated Skera table tree.