Repository navigation
Conversation
behdad
force-pushed
the
skera-base-version
branch
from
October 10, 2026 18:08
5ad64bc to
aa337d7
Compare
behdad
force-pushed
the
skera-base-version
branch
from
October 12, 2026 03:19
aa337d7 to
51e3228
Compare
behdad
force-pushed
the
skera-base-version
branch
from
October 12, 2026 20:41
51e3228 to
575bc2e
Compare
behdad
force-pushed
the
skera-base-version
branch
from
October 12, 2026 20:53
575bc2e to
34ddfb0
Compare
behdad
force-pushed
the
skera-base-version
branch
from
October 12, 2026 22:04
34ddfb0 to
7e5a785
Compare
behdad
force-pushed
the
skera-base-version
branch
from
October 14, 2026 23:11
7e5a785 to
8a85f51
Compare
Propagate reviewed fixes and repaired ancestry through #2275. Assisted-by: OpenAI Codex
This tree is unchanged; the replacement evaluator already handles missing variation rows. Preserve the repaired parent ancestry. Assisted-by: OpenAI Codex
Preserve reviewed parent ancestry and each PR's existing feature changes. Assisted-by: OpenAI Codex
Preserve the independently validated TrueType changes and all feature code. Assisted-by: OpenAI Codex
Keep empty record counts and allocation bounds at each PR boundary. Assisted-by: OpenAI Codex
Contributor
Author
|
Self-review completed at the prepared #2275 boundary:
No new defect found in this slice. All three BASE integration tests pass at the prepared boundary, including horizontal/vertical axes, null stores, pins/ranges, and a subsequent subset. They also pass with all three references freshly regenerated using current HarfBuzz. Parent layout precision and ownership corrections remain included. |
Contributor
Author
|
The reviewed parent fixes are now pushed. No new BASE defect was found: all three integration tests pass at this boundary with freshly regenerated HarfBuzz references, including the null 1.1 store field and retained coordinate formats. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BASE subsetting downgraded a 1.1 table to 1.0 when its variation-store offset was null. Instancing did the same after removing the store, and converted resolved format-3 coordinates to format 1. These changes preserved the coordinates but introduced unnecessary structural differences from HarfBuzz.
Preserve the source BASE version and its required null Offset32 field through ordinary subsetting and instancing. Keep format-3 coordinates after resolving their variation devices, following HarfBuzz's BASE subset path. A small writer wrapper retains the source version without changing the public owned BASE representation.
Validation: all 215 skera unit tests, three new BASE integration tests, existing layout precision tests, Clippy, formatting, and the CI typos checker pass. Three synthetic table references match fresh local HarfBuzz c82300aefb. BASE tables also match in 27 ordinary subset cases and 49 full/partial instancing cases across nine and six source fonts respectively, with no shaping differences.
Stacked on #2274.
Readers use read-fonts directly. write-fonts handles font assembly and owned table rebuilding; Skera retains its direct serializers and repacker. There is no separate generated Skera table tree.