Repository navigation
Conversation
7 of 12 tasks
behdad
force-pushed
the
skera-cff-review-precision
branch
2 times, most recently
from
October 10, 2026 02:47
7ca2972 to
c2fd97e
Compare
This was referenced Oct 10, 2026
behdad
force-pushed
the
skera-cff-review-precision
branch
from
October 10, 2026 18:08
c2fd97e to
11d85fe
Compare
behdad
force-pushed
the
skera-cff-review-precision
branch
from
October 12, 2026 03:19
11d85fe to
5c7568f
Compare
behdad
force-pushed
the
skera-cff-review-precision
branch
from
October 12, 2026 20:41
5c7568f to
1106b7d
Compare
behdad
force-pushed
the
skera-cff-review-precision
branch
from
October 12, 2026 22:04
1106b7d to
80eafff
Compare
behdad
force-pushed
the
skera-cff-review-precision
branch
from
October 14, 2026 23:11
80eafff to
368ce8a
Compare
Resolve integration conflicts without dropping validated parent fixes. Assisted-by: OpenAI Codex
Contributor
Author
|
Review findings before changes:
I will make the normalization cleanup, run the Skera suite and comparison matrices at this boundary, and update the description. |
Each outline coordinate is filled by the explicit normalization path; metric coordinates are computed separately below. Initialize the vector directly. Assisted-by: OpenAI Codex
Contributor
Author
|
Pushed the reviewed parent and the precision cleanup through the stack. Axis planning now initializes the outline-coordinate buffer directly instead of computing and cloning a normalization result that was immediately overwritten. The reviewed boundary passes 466 Skera tests, the shared reader regression, Clippy and Rust 1.85 checks; the 90 full / 38 partial CFF comparisons retain their results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fractional CFF2 locations need separate normalization paths for outline/store instancing and runtime metrics. Match HarfBuzz's float normalization and half-unit rounding toward positive infinity; keep the metric path's intermediate 16.16 normalization before its 2.14 coordinates.
Use the shared unquantized float-region-scalar helper, double CFF operand products/accumulation, consumer-specific metric arithmetic, and a continuous bounds action on the common Type 2 interpreter. Full output retains per-blend rounding; bounds evaluate without operand rounding. Initialize outline coordinates directly instead of computing and discarding a second normalization result and clone.
Validation: 466 Skera tests with all features, the shared-reader scalar regression, Clippy with warnings denied, and Rust 1.85 all-target/all-feature checks. The current review's 90 full and 38 partial CFF comparisons pass, including decoded outlines, metrics, axis records, Private DICTs, and second-stage samples. Partial re-encoding retains its documented coefficient/F2Dot14 quantization limits.
Stacked on #2264 and preserves its reviewed nested-expression and performance fixes. Shared reader APIs provide the scalar evaluation; write-fonts supplies owned table models and assembly. No secondary generated table tree.