Repository navigation
Fix runtime errors in add_responsive_search_ad_full.rb - #576
Open
pattersonlois wants to merge 2 commits into
Open
pattersonlois wants to merge 2 commits into
pattersonlois wants to merge 2 commits into
Conversation
pattersonlois
requested review from
BenRKarl and
dorasun
and removed request for
a team
November 16, 2026 17:27
Contributor
Author
|
Note for review on coordination with #575:
|
Contributor
Author
|
Made fixes following dorasun's Google doc feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.operation.create_*,client.enum.served_asset_field_type.HEADLINE_1, andclient.request.suggest_geo_target_constantscalls withclient.operation.create_resource.*,:HEADLINE_1, andclient.resource.location_names+ keyword arguments onsuggest_geo_target_constants.customizer_attribute_name(instead ofcustomizer_attribute_resource_name) into{CUSTOMIZER.<name>:10USD}, and make-n/--customizer-attribute-nameoptional (nildefault instead of forcing"Price") so repeat runs do not fail withDUPLICATE_CUSTOMIZER_ATTRIBUTE_NAMEand both description branches remain reachable.contains_eu_political_advertisingandclient.resource.target_spend(omitting read-onlybidding_strategy_typeand deprecatedtarget_spend_micros) increate_campaign.require 'securerandom', unescape#{SecureRandom.uuid}andputsresource-name interpolations, fix theLOCALEdefault comment ('en') and DevSite customizer/geotargets URLs, renamemain_functiontoadd_responsive_search_ad_full, and align CLIOptionParser(-h/--help) andGoogleAdsError/KeyErrorSTDERRhandling with repository conventions.