Repository navigation
Shrink TransposeDecoder failure sentinel padding and use inline node storage - #49
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1011381055
branch
from
November 3, 2026 05:16
fdbbdcf to
6c2340b
Compare
copybara-service
Bot
force-pushed
the
test_1011381055
branch
from
November 3, 2026 05:17
6c2340b to
af3e38d
Compare
…storage Reduces per-chunk setup overhead in `riegeli::TransposeDecoder::Parse`: 1. Shrinks the failure sentinel padding from 255 to `kNumFailureSentinelNodes = 64` nodes (the maximum transition step offset is `0xff >> 2 == 63`, checked by a `static_assert`). 2. Replaces the heap-allocated `std::vector<StateMachineNode>` with inline storage in `Context` (`inline_nodes[128]`: up to 64 active nodes plus 64 sentinels, ~3 KiB on `Decode`'s stack), falling back to `std::unique_ptr<StateMachineNode[]>` for larger schemas, and deletes `Context` copy/move because `state_machine_nodes` may point into `inline_nodes`. 3. Explicitly initializes `tag_data_size` (and `is_implicit` on sentinels), which `std::vector::resize` previously value-initialized. 4. Passes `absl::Span<const StateMachineNode>` (active nodes only) to `ContainsImplicitLoop` and replaces its `std::vector<size_t>` with `absl::FixedArray<uint32_t, Context::kInlineActiveNodes>`. PiperOrigin-RevId: 1011381055
copybara-service
Bot
force-pushed
the
test_1011381055
branch
from
November 3, 2026 05:47
af3e38d to
befbca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shrink TransposeDecoder failure sentinel padding and use inline node storage
Reduces per-chunk setup overhead in
riegeli::TransposeDecoder::Parse:kNumFailureSentinelNodes = 64nodes (the maximum transition step offset is0xff >> 2 == 63, checked by astatic_assert).std::vector<StateMachineNode>with inlinestorage in
Context(inline_nodes[128]: up to 64 active nodes plus 64sentinels, ~3 KiB on
Decode's stack), falling back tostd::unique_ptr<StateMachineNode[]>for larger schemas, and deletesContextcopy/move becausestate_machine_nodesmay point intoinline_nodes.tag_data_size(andis_impliciton sentinels),which
std::vector::resizepreviously value-initialized.absl::Span<const StateMachineNode>(active nodes only) toContainsImplicitLoopand replaces itsstd::vector<size_t>withabsl::FixedArray<uint32_t, Context::kInlineActiveNodes>.