Repository navigation
check the predicate on entries from filterEntries entrySet().toArray() - #8758
Open
arshsmith1 wants to merge 1 commit into
Open
arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
FilteredEntryMap.EntrySet wrapped only the entries returned by iterator(), so the entries returned by toArray() were the backing map's own entries and their setValue bypassed the filter. Override toArray the same way AbstractBiMap.EntrySet and UnmodifiableEntries do.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps.filterValuesandMaps.filterEntriesdocument thatEntry.setValuethrowsIllegalArgumentExceptionfor a value the predicate rejects, butFilteredEntryMap.EntrySetonly wraps the entries handed out byiterator().entrySet().toArray()andtoArray(T[])forward to the underlying filtered set and return the backing map's own entries, so((Entry<String, Integer>) view.entrySet().toArray()[0]).setValue(-1)writes a rejected value through a view that refuses the same write viaput, the iterator,replaceAll,mergeandcompute. Overriding bothtoArraymethods withstandardToArray()is the same guardAbstractBiMap.EntrySetandMaps.UnmodifiableEntriesalready use against theCheckedEntrySetattack; the new test inAbstractFilteredMapTestfails before the change for the Map, SortedMap and BiMap variants and passes after.