Repository navigation
chore: recompile Cloud Hypervisor enclave smoke with selected compiler - #10035
Merged
Merged
Conversation
Use the selected local compiler and immutable gh-aw runtime ref. Preserve release pins and metadata-write safety; document failed scanner gates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 14810de3-06c0-4ec9-885f-f5c1be7259e8
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
Replace the timed-out man7.org mount(8) URL with the util-linux source manual, preserving the remount semantics reference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 14810de3-06c0-4ec9-885f-f5c1be7259e8
Contributor
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit d72fd36 |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Failed scanner gates, uncertain compiler provenance, and unresolved evidence-collection prerequisites require human review.
2 open findings
What changed in this PR
Recompiles the experimental Cloud Hypervisor enclave smoke using the selected local compiler and immutable runtime ref.
Changes:
- Regenerates the workflow lock and records compiler/setup provenance.
- Updates focused regression expectations while preserving AWF and Copilot versions.
- Replaces a mount-semantics documentation link.
| File | Description |
|---|---|
scripts/ci/smoke-enclave-workflow.test.ts |
Updates compiler, setup-pin, and safety expectations. |
docs/cloud-hypervisor-foundation.md |
Updates the mount documentation link. |
.github/workflows/smoke-enclave-cloud-hypervisor.md |
Documents provenance and validation limits. |
.github/workflows/smoke-enclave-cloud-hypervisor.lock.yml |
Records regenerated workflow and setup refs. |
.github/aw/actions-lock.json |
Adds the selected setup-action pin. |
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Setup Scripts | ||
| id: setup | ||
| uses: github/gh-aw-actions/setup@458b269006dcf88e3b5496b6fbecabe4b9a0f954 # v0.92.0 | ||
| uses: github/gh-aw/actions/setup@0abe2d9b233658150bc05ea968f1736b94093cf7 # 0abe2d9b233658150bc05ea968f1736b94093cf7 |
Comment on lines
+323
to
+325
| expect(compiled.jobs.activation.steps.some(step => | ||
| step.name === 'Check compile-agentic version')).toBe(false); | ||
| expect(lock).not.toContain("require(path.join(actionsDir, 'check_version_updates.cjs'))"); |
Collaborator
Author
|
@copilot address review feedback |
Contributor
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Targeted recompile of
smoke-enclave-cloud-hypervisorusing the exact user-selected local binary and immutable runtime ref. Includes only its source/lock, the required new action-lock entry, and focused regression expectations. No other workflow locks changed; no generated YAML was hand-edited.Postprocessing ran after every generation, including diagnostic locks. Diagnostic output was preserved privately and the normal candidate restored, not replaced by a staged dry-run workflow.
Compiler and runtime provenance
gh-aw/work-queue/5eb4c298ecba515924d30bd7989113dd79d7d421-14-g7dc6abab7a-dirty.4eef9ae379b3bb0199e7a2ab3203633563c0574cb1405be8891b483486bbcec6.7dc6abab7ad723cd98f18b5c521d896ed7ffcdc7,vcs.modified=true. This identifies reported build provenance, not authenticated exact dirty source. The compiler checkout and executable were not modified.github/gh-aw/actions/setup@0abe2d9b233658150bc05ea968f1736b94093cf7.--gh-aw-refpins runtime actions; it does not identify the local compiler build.56a8d2b93f37634d540b6731ff84050f9dba27b3; both scanner-fix implementation blobs are identical at the two refs (aa7ad567286ecab7c52b5cc8a4f8885c0aca5563,e5ea7bc625c4df12decd560a4887109c4746c66f). GitHub returns no current branch headed by the selected SHA. Commit existence does not clear zizmor's findings.The normal lock updates compiler attribution and setup refs, reports
GH_AW_VERSION: dev, and omits release CLI version metadata and the release-version check. The omitted step enforces release revocation/minimum-version policy for release builds; it would skip a nonrelease/dev build. This candidate has no equivalent release-version gate, so this is not merely a cosmetic change.Preserved controls / unresolved prerequisites
AWF remains
v0.28.59, Copilot1.0.96, and all seven manifest image/digest records are unchanged. Release-attestation provisioning remains. The exact existing/tmp/gh-aw/aw_info.jsonwrite exception and contextual mkdir correction from #10031 remain; neighboring framework paths are not opened. VM/network isolation, token/capability exclusions, one static public script enclave, one invocation/120 seconds, zero retries, no issue writes, and existing 20-minute agent/safe-output job bounds remain. Other generated jobs still have no 20-minute bound; no workflow-wide bound is claimed.Host-only public-fixture debug collection remains owner-protected, explicitly allowlisted and bounded, with one-day retention. The early
AWF_RESOLVED_CONFIGredaction/collection gap is NOT fixed: selected consumers still use the old audit paths. No raw config copy or redaction bypass was added. The separate failed enclave launch remains unverified. Keep draft; no live run is authorized.Validation
git diff --checkpassed.impostor-commitfindings on diagnostic setup refs, plus SHA-only version-comment and activationsecrets-outside-envpolicy findings. Experimental notice acceptance did not suppress those findings.impostor-commit, four Mediumref-version-mismatch. Native actionlint 1.7.12 also reports unknowncopilot-requestspermission andconcurrency.queuesyntax in the normal lock; that normal-lock result is distinct from compiler-reported diagnostic actionlint success.No workflow execution, dispatch/rerun, live dry-run, KVM boot, release, merge, Agent merge, or automation was requested or performed. Hosted auth/approval, live model compatibility, and original VM/enclave failures remain unverified.
Authored Markdown overview
Exact artifacts (SHA256)
dea60699ebaed7d60c88433edb95f3f03d7f892b66aefd0d1928999a676aef601d0434cb7aedb9f9db85c1468190cec45f2436917a0b21867b91b28315e1b9d94dd14ba5d1563791ac2a5b721a80c6a109a3bb1f2ab5a9210b24c80b65b400beTrusted base:
c774e851f861c255e5cdec2affaf789826562df4.