Repository navigation
Pin client-rust at 18eff6d (integration on upstream 1b883bf); delete pre-557 - #79
Merged
Merged
Conversation
upstream master now contains #557, so the only client-rust the upstream view builds against has MultipleRegionErrors; the ExtractedErrors arms cannot compile anywhere any more (ADR-0001). Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
integration merged upstream master 1b883bf (getwyrd/client-rust#3): #557 and #551 are now in upstream_base, #558 is still carried. A reviewed pin bump (ADR-0001); the evidence at this pin follows in its own commit. Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
ledger-check refuses results produced against a pin that pins.toml no longer names, so the fixture recorded at b10bc69 failed 15 of the candidate-mode tests. Re-recorded from a real candidate run (PARITY_MODE=candidate PARITY_GAP=G-0002 make ledger, client-rust at 18eff6d plus one uncommitted line, leased v8.5.5 cluster), not edited by hand. Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
eduralph
added a commit
that referenced
this pull request
Oct 20, 2026
Each was a standing rule before it was written down, and every gate and ledger run exercises it; the pin move at 18eff6d (#79) exercised 0006 and 0007 again. Signed-off-by: Eduard Ralph <eduard@ralphovi.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync after tikv/client-rust merged #557 and #551 (getwyrd/client-rust#3 merged upstream
master1b883bfintointegration). A reviewed pin bump per ADR-0001.pins.toml:rev=18eff6d(the merge),upstream_base=1b883bf.integrationnow carries only #558 (still open upstream) and the fork'sAGENTS.md.pre-557deleted: the Cargo feature, thecfgarms and the pre-557-only test inmapping.rs, the two CI steps, and the Makefile'sDRIVER_FEATUREShook.upstream_basecontains #557, so the upstream view builds with no switch.findings/gate-evidence-18eff6d.txt, captured on a clean harness (c27a931) against a leased single-node v8.5.5 cluster withPARITY_STRICT=1: the gate is all green (18 + 1 passed,d6andd7included), the ledger holds (G-0001 HOLDS, G-0002 XDIVERGE exactly as declared), and the upstream view at1b883bfexits 0. No ledger claim moved.18eff6d;b10bc69moves to History.ledger-checkrefuses results produced against a pinpins.tomlno longer names, which failed 15 tests with the old fixture.make checkpasses locally; adversarial review clean.