Repository navigation
Fix fatal crash when Android rejects a Passpoint configuration - #179
Merged
Merged
Conversation
WifiNetworkSuggestion.Builder().setPasspointConfig() validates the config and throws IllegalArgumentException if the device considers it invalid (bad FQDN, cert chain, etc). buildPasspointSuggestion() called this unguarded, and its only caller, WifiConfigViewModel.handleAndroid11PhoneOrTablet(), only wraps the later addNetworkSuggestions() call in try/catch - the construction itself, one line above, was never covered (Crashlytics issue 8324db8833a64dfa92a387c42c6df92e, #2 crash of the last 30 days). buildPasspointSuggestion() already returns a nullable WifiNetworkSuggestion, and both existing call sites already treat null as "skip the Passpoint suggestion, fall back to SSID suggestions" - same as the other validation failures already handled in buildPasspointConfig() a few lines up. Catching here reuses that existing contract instead of duplicating handling at each call site.
dzolnai
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding try/catch block around Passpoint builder that would occasionally cause problems when provided with an invalid configuration.