Repository navigation
fix: improve genstubs and some related bugs - #1781
Open
jakelorocco wants to merge 2 commits into
Open
jakelorocco wants to merge 2 commits into
jakelorocco wants to merge 2 commits into
Conversation
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
jakelorocco
force-pushed
the
fix/genstubs
branch
from
November 3, 2026 13:19
bb6d27e to
b8f80d6
Compare
jakelorocco
marked this pull request as ready for review
November 3, 2026 20:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1476
Description
Improves genstub performance by modifying the template. On set of genstub tasks based on our examples and other scenarios, performance improved by 3.1% averaged across models and sizes. Granite models saw large improvements along with models with thinking on.
Performance saw large improvements when including the return format in the prompt.
Additional bug fixes:
-> X | Nonestubs crashed when the right answer wasNone. When the model correctly returned {"result": null}, a check in mellea/core/base.py required every result to be non-None and raised an AssertionError.a. docstrings left out when empty instead of rendering as
""""""b. argument types fixed
c. removed module paths from types
d. pydantic arguments are rendered as json along with dicts and lists
e. unquoted unresolved return types to prevent small models from returning strings
f. multiline docstrings keep their indentation
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.