Repository navigation
Post petsctools.Options improvements to OptionsManager - #57
Merged
Merged
Conversation
This means that we get the right option types when we read from petsctools.Options later on.
JHopeCollins
reviewed
Oct 9, 2026
JHopeCollins
requested changes
Oct 9, 2026
JHopeCollins
left a comment
JHopeCollins
left a comment
Member
There was a problem hiding this comment.
Every time I think we're converging on the right thing, you manage to find a way to simplify it!
Looks like now the only place we need to worry about whether options are native or python types is in petsctools.Options?
Collaborator
Author
Yep! |
Co-authored-by: Josh Hope-Collins <jhc.jss@gmail.com>
Collaborator
Author
|
Turns out that >>> print(PETSc.Options("").prefix)
Noneso the |
Member
That is rather vexing |
Collaborator
Author
|
JHopeCollins
approved these changes
Oct 9, 2026
JHopeCollins
left a comment
JHopeCollins
left a comment
Member
There was a problem hiding this comment.
I'm very happy with this, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
petsctools.OptionsasOptionsManager.options_object. This means that we can get the right types withpetsctools.Options.__getitem__later on.AppContextManager. Sincepetsctools.OptionsDTRT when we pass Python options we can rely on it to correctly push and pop things from the global state.