Repository navigation
Ignore local tests/elm_home - #289
Merged
Merged
Conversation
Previously:
❯ npm test >/dev/null && npx elm-review
-- ELM-REVIEW ERROR ----------------------------------------------- GLOBAL ERROR
Incorrect project: Found several modules named `AsciiTable`
I found several modules with the name `AsciiTable`. Depending on how I choose to
resolve this, I might give you different reports. Since this is a compiler error
anyway, I require this problem to be solved. Please fix this then try running
`elm-review` again.
Here are the paths to some of the files that share a module name:
- src/AsciiTable.elm
- tests/elm_home/0.19.2/packages/elm-explorations/test/2.2.1/src/AsciiTable.elm
It is possible that you requested me to look at several projects, and that
modules from each project share the same name. I don't recommend reviewing
several projects at the same time, as I can only handle one `elm.json`. I
instead suggest running `elm-review` twice, once for each project.
I found 1 global error.
For that reason, the "review" script in package.json removed
`tests/elm_home` before running elm-review.
We also had to list specific directories for the "format" script.
That list of directories was missing the `review/` folder.
This commit changes the local `ELM_HOME` directory we use in
`run-tests.sh` to include "elm-stuff", so that elm-review and elm-format
ignore it. It also results in intellij-elm ignoring it, insteading
reporting that functions are used in duplicate places. This commit then
simplifies the "review" and "format" scripts.
Janiczek
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
For that reason, the "review" script in package.json removed
tests/elm_homebefore running elm-review.We also had to list specific directories for the "format" script. That list of directories was missing the
review/folder.This commit changes the local
ELM_HOMEdirectory we use inrun-tests.shto include "elm-stuff", so that elm-review and elm-format ignore it. It also results in intellij-elm ignoring it, insteading reporting that functions are used in duplicate places. This commit then simplifies the "review" and "format" scripts.