Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Annotation relocation skips attached JAR source and can fail for renamed or deleted methods, while breakpoint mode switching and marker tracking lack automated regression coverage.
3 open issues
What changed in this PR
Updates Java method breakpoint annotations to appear at the closing brace for exit-only breakpoints and at the method declaration when entry is enabled.
Changes:
- Centralizes marker relocation and applies it when entry/exit settings change.
- Changes editor toggling to switch existing breakpoint modes in the specified cases instead of deleting the breakpoint.
- Tracks the exit-only marker’s line after document edits.
| File | Description |
|---|---|
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/BreakpointUtils.java |
Adds shared method breakpoint marker relocation. |
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/breakpoints/MethodBreakpointEditor.java |
Relocates the marker when breakpoint properties are saved. |
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/BreakpointMarkerUpdater.java |
Tracks closing-brace marker lines after edits. |
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/actions/ToggleBreakpointAdapter.java |
Switches existing breakpoint modes and positions new exit-only markers. |
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/actions/ExitToggleAction.java |
Refreshes marker placement after toggling exit mode. |
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/actions/EntryToggleAction.java |
Refreshes marker placement after toggling entry mode. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Active issues leave exit-only breakpoints misplaced in source-attached class files, retain markers for deleted methods, and make new tests vulnerable to toggle-job timing races.
3 open issues
3 resolved since last review
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The marker checks can delete valid exit breakpoints on save when markers remain declaration-anchored or tracked positions expand after edits before the closing brace, requiring anchoring fixes and regression coverage.
2 open issues
3 resolved since last review
Review effort: Balanced
SougandhS
marked this pull request as draft
November 14, 2026 05:22
Toggling a method exit breakpoint on the closing brace created the breakpoint, but its annotation stayed on the method declaration line. Place the marker on the closing brace for exit-only breakpoints, and on the method line when entry is also enabled. Toggling on the closing brace of an existing method breakpoint now switches its exit mode instead of deleting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggling a method exit breakpoint on the closing brace created the breakpoint, but its annotation stayed on the method declaration line. Place the marker on the closing brace for exit-only breakpoints, and on the method line when entry is also enabled. Toggling on the closing brace of an existing method breakpoint now switches its exit mode instead of deleting it & Toggling on the method line of an existing method exit breakpoint now switches its entry + exit mode instead of deleting it
Screen.Recording.2026-11-14.at.9.55.47.AM.mov
Author checklist