Skip to content

refactor: use item access for result rows #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e10v merged 1 commit into from
Jul 8, 2026
Merged

refactor: use item access for result rows #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/tea_tasting/backends/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def _get_aggregates(
return _get_row_aggregates(_ResultRow(data[0]), aggr_cols)

return {
row.get(group_col): _get_row_aggregates(row, aggr_cols)
row[group_col]: _get_row_aggregates(row, aggr_cols)
for row in (_ResultRow(row_data) for row_data in data)
}

Expand All @@ -126,7 +126,7 @@ def __init__(self, data: Mapping[str, object]) -> None:
self.data = data
self.casefold_keys = _casefold_keys(data)

def get(self, key: str) -> object:
def __getitem__(self, key: str) -> object:
if key in self.data:
return self.data[key]

Expand All @@ -152,13 +152,10 @@ def _get_row_aggregates(
aggr_cols: tea_tasting.aggr.AggrCols,
) -> tea_tasting.aggr.Aggregates:
return tea_tasting.aggr.Aggregates(
count_=int(data.get(_COUNT)) if aggr_cols.has_count else None, # ty:ignore[invalid-argument-type]
mean_={col: _float(data.get(_MEAN.format(col))) for col in aggr_cols.mean_cols},
var_={col: _float(data.get(_VAR.format(col))) for col in aggr_cols.var_cols},
cov_={
cols: _float(data.get(_COV.format(*cols)))
for cols in aggr_cols.cov_cols
},
count_=int(data[_COUNT]) if aggr_cols.has_count else None, # ty:ignore[invalid-argument-type]
mean_={col: _float(data[_MEAN.format(col)]) for col in aggr_cols.mean_cols},
var_={col: _float(data[_VAR.format(col)]) for col in aggr_cols.var_cols},
cov_={cols: _float(data[_COV.format(*cols)]) for cols in aggr_cols.cov_cols},
)


Expand Down
Loading