Repository navigation
Fix an invalid account's message, the gas price's decimals, success text and the network dot - #321
Merged
Merged
Conversation
…he network dot - An invalid account address says so, and asks the node nothing about it, rather than saying the last block couldn't be read. - The average gas price is rounded to two decimals. - Success text on badges and toasts uses the darker green, 5.5:1 on the light page rather than 3.8:1. - The node is asked every minute while the tab shows, and once as it comes back. When it doesn't answer, the network dot turns amber and says so, and turns back when it answers again. What it said it was stays, and the store changes only when that does, so nothing is drawn again for nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Fixes #71
Fixes #18
Fixes #19
Checks:
npm run checkspasses, and each new test fails without its fix. In a browser, with the node's answers blocked and then unblocked, the dot changed and recovered.