Repository navigation
test: drop the file snapshots - #319
Merged
Merged
Conversation
52,308 lines of snapshots, about four times the app's code, caught 1 of 20 bugs planted at random on their own, and turned small changes into diffs of thousands of lines. A test whose only check was a snapshot goes, and the behaviours worth keeping get real checks. Inline snapshots stay: they compare exact values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 52,308 lines of file snapshots, about four times the app's own code. On their own they caught 1 of 20 bugs planted at random, and they turned small changes into diffs of thousands of lines.
A test whose only check was a snapshot goes. Behaviour worth keeping gets a real check: Show more hidden after an error, the failed-transaction tooltip, and a disabled link. Inline snapshots stay, because they compare exact values.
Note: planted bugs were in script logic, not page markup, so a change in markup alone is now less likely to fail a test.
Tests: 678 → 601, all passing.