Repository navigation
FEATURE: Update launcher to load base_image from templates - #1152
Open
davidtaylorhq wants to merge 1 commit into
Open
davidtaylorhq wants to merge 1 commit into
davidtaylorhq wants to merge 1 commit into
Conversation
This matches the behavior of launcher v2, and allows us to drop the docker image variable from the launcher script itself. Also introduces a `web.webonly` template which tracks the `-web-only` version of the base image. This can be added *after* `web.template` in a container definition, and will override its base_image.
ZogStriP
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of launcher v2, and allows us to drop the docker image variable from the launcher script itself.
Also introduces a
web.webonlytemplate which tracks the-web-onlyversion of the base image. This can be added afterweb.templatein a container definition, and will override its base_image.