Repository navigation
Fix CI check failure on PR #59 by suppressing Ruff PLR0917 on existing constructors - #60
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix mypy typing issues in breds
Fix CI check failure on PR #59 by suppressing Ruff PLR0917 on existing constructors
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the failing GitHub Actions job for PR #59 in
code_checks.yml. The reported failure pointed at type checking, but the workflow was actually failing earlier in Ruff onPLR0917for several existing constructor signatures, which preventedmypy -p bredsfrom running in CI.CI failure source
Lint and format checkstep failed on five constructor definitions withPLR0917(Too many positional arguments).breds; the failure was from lint enforcement rather than a type-safety issue.Scoped code changes
# noqa: PLR0917suppressions to the affected constructors in:breds/bootstrapping.pybreds/breds_tuple.pybreds/config.pybreds/sentence.pyWhy this shape