Repository navigation
Correct documented configuration names and palette values - #988
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Copying the README's complete configuration example into a file and loading it with
--load-configexits withunknown variant Username: the column kind isUser.The same reference also lists the nonexistent
WriteBytekind and the literalColor256as an available style/color. The parser acceptsWriteBytesand numeric-string palette entries such as"223", not those listed tokens.Change
Correct these configuration instructions together and add a pure parsing regression for the README's complete TOML example. No production behavior changes.
Validation
--no-default-featureson Windows x86_64, Rust 1.98.1.cargo fmt -- --checkpasses.src/columns/priority.rs:140–144on base and the audited changes, in both feature configurations.