Skip to content

Correct documented configuration names and palette values - #988

Open
dajiaohuang wants to merge 1 commit into
dalance:masterfrom
dajiaohuang:docs/configuration-values-20261015
Open

dajiaohuang wants to merge 1 commit into
dalance:masterfrom
dajiaohuang:docs/configuration-values-20261015

Conversation

@dajiaohuang

Copy link
Copy Markdown

Problem

Copying the README's complete configuration example into a file and loading it with --load-config exits with unknown variant Username: the column kind is User.

The same reference also lists the nonexistent WriteByte kind and the literal Color256 as an available style/color. The parser accepts WriteBytes and numeric-string palette entries such as "223", not those listed tokens.

Change

Correct these configuration instructions together and add a pure parsing regression for the README's complete TOML example. No production behavior changes.

Validation

  • The original example fails through the CLI configuration loader before process collection; the parsing regression fails on base and passes after the correction.
  • Regression passes with default features and --no-default-features on Windows x86_64, Rust 1.98.1.
  • Verified the corrected kind and palette tokens with the production configuration parser.
  • cargo fmt -- --check passes.
  • Full process-collecting tests were not run on the shared host. Clippy reports the same five pre-existing unnecessary casts at src/columns/priority.rs:140–144 on base and the audited changes, in both feature configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant