You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(settings): make shortcut recording keyboard accessible - #1497
Shortcut settings used a click-only element to start recording and then captured keys across the whole window. Use a native button that keeps focus while it records. Enter and Space start recording; Escape and moving focus cancel it without changing the binding. Reset and Clear now identify the shortcut they act on, and Clear is visible when tabbing through the row.
Validated with lint, type checking, a production frontend build, 91 shortcut and settings tests, and a Chromium smoke test for keyboard activation, focus, cancellation and saving.
Summary by CodeRabbit
New Features
Keyboard shortcuts can now be recorded directly from their focused controls. Escape cancels recording, and recording stops if the control loses focus.
No actionable comments were generated in the recent review.
Walkthrough
Shortcut rows now record keys through a focused button instead of a global listener. The handler applies key filtering and cancellation rules. The button shows recording status and the current binding, and reset and clear controls are hidden during recording.
The row button starts recording and receives focus. Its keydown handler rejects repeated, composing, and modifier-only events, preserves unmodified Tab for navigation, and cancels on Escape. Accepted keys are stored with modifier flags. The button displays recording status or the current binding; reset and clear controls are hidden while recording. Accessible labels describe the controls and shortcut.
Shortcut recording now works from the keyboard through a native button, and Reset and Clear are labelled for the shortcut they affect. No merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title uses the Conventional Commits format (type fix, scope settings) that the configured requirement asks for. It clearly names the main change: shortcut recording in settings becomes keyboard ac…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title uses the Conventional Commits format (type fix, scope settings) that the configured requirement asks for. It clearly names the main change: shortcut recording in settings becomes keyboard accessible. This matches the summary, which replaces the click-only Recorder with a focused button that handles Enter/Space activation, Escape cancellation, and labelled reset and clear controls.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between b217c43 and 6c9b12c.
Files selected for processing: 1
src/settings/sections/ShortcutsSection.tsx
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcut settings used a click-only element to start recording and then captured keys across the whole window. Use a native button that keeps focus while it records. Enter and Space start recording; Escape and moving focus cancel it without changing the binding. Reset and Clear now identify the shortcut they act on, and Clear is visible when tabbing through the row.
Validated with lint, type checking, a production frontend build, 91 shortcut and settings tests, and a Chromium smoke test for keyboard activation, focus, cancellation and saving.
Summary by CodeRabbit