Repository navigation
Conversation
Not up to standards ⛔
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WelchPeriodogramcomputes its PSD with the supplied sampling rate but constructs the returnedSpectrumwith sampling 1 and the input length as its FFT length. Its frequency metadata can disagree with the PSD even though the raw Matplotlib result is correct.For example, a 32 Hz sinusoid sampled at 256 Hz returns a raw peak at 32 Hz while
Spectrum.frequencies()labels it 0.125 Hz. Default segment lengths andpad_tocan also leave the frequency vector with a different length from the PSD.Forward the sampling rate and effective FFT length into
Spectrum, using Matplotlib's default of 256 whenNFFTis omitted andpad_towhen specified. PSD computation remains the existing Matplotlib call.Validation:
The recording check covers real inputs. Linux/Python 3.12 validation; other platforms are untested.