Skip to content

repair duplicate checking in import - #1089

Merged
mflatt merged 1 commit into
cisco:mainfrom
mflatt:fix-929
Nov 4, 2026
Merged

mflatt merged 1 commit into
cisco:mainfrom
mflatt:fix-929

Conversation

@mflatt

@mflatt mflatt commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This is an adjusted and completed version of #987 to fix #929 — using the alternate repair noted in #987 that I think is more right, adding the test from the #929, and adding a release note.

Comment thread release_notes/release_notes.stex Outdated

\subsection{Repair duplicate checking in \scheme{import} (10.5.0)}

Repair checking of duplicates names on \scheme{import} in the case of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicates => duplicate

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like I also lost an extra sentence here that was meant to be included, so I'd welcome another look.

Compare labels, not labels potentially annotated with properties.

@burgerrg burgerrg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@mflatt
mflatt merged commit 14f0891 into cisco:main Nov 4, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combination of re-exports with identifier properties and renaming imports causes spurious ‘multiple definitions’ errors

3 participants