Repository navigation
Conversation
Adds suite/run_cstool_output.sh, which compares cstool output byte for byte against the expected columns and spacing, and runs it in CI. Closes capstone-engine#2740.
Collaborator
|
Obviously ignores our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLACEHOLDER - NOT A PR DESCRIPTION.
capstone forbids AI-written PR descriptions and commit messages (CONTRIBUTING.md,
AGENTS.md). Replace this field and the commit message with your own text before
publishing.
Reference notes for the owner:
Where: new file suite/run_cstool_output.sh plus one CI step in
.github/workflows/CITest.yml. Addresses issue #2740.
What it does: runs cstool four times and compares stdout byte for byte against
the expected text, so the offset column, the byte column, the mnemonic/operand
tab and the widened address column cannot drift without CI noticing. Failures
print a unified diff.
Coverage: multi instruction stream (x64), a shorter stream with a different
bytes width (aarch64), a start address widening the offset column (x64), and
thumb mode (arm).
CI step is guarded with
if: matrix.config.diet-build == 'OFF', because dietbuilds drop the detail this layout depends on.
Tested: script exits 0 on a full build; editing one expected line makes it exit
1 and print the diff. CITest.yml parses as YAML.