Skip to content

Fix wheel compilation and nightly QP regressions - #2923

Merged
dellaert merged 1 commit into
developfrom
codex/fix-wheel-and-nightly-qp
Nov 8, 2026
Merged

dellaert merged 1 commit into
developfrom
codex/fix-wheel-and-nightly-qp

Conversation

@dellaert

@dellaert dellaert commented Nov 8, 2026

Copy link
Copy Markdown
Member

Summary

Addresses the develop wheel build failure and the distinct failures reported in #2915, based on develop 444863c614609e0e4ec5e8c80819243cd14c815d.

  • Avoid the temporary optional argument in cachedOrdering, which triggers GCC's -Werror=dangling-reference in the wheel builds and Linux vcpkg build. Preserve cached ordering by reference and test the explicit LP ordering path.
  • Apply bounded homogeneous residual corrections in SparseQpSolver using the existing factorization. Re-solving with the stored affine right-hand side reintroduces cancellation along weak directions. Keep the existing bound-release regression and add a deterministic unequal-column regression.
  • Preserve the legacy QPSolver supplied-point contract by selecting Primal explicitly. Automatic can select Dual, which accepts infeasible starts; the legacy interface must reject them. Cover both supplied-point overloads without relaxing the original solution tolerance.
  • Replace the ARM weak-affine-face test's fixed 5e-9 forward-error threshold with epsilon * condition * solution magnitude, derived from its reduced Hessian. Its condition number is about 4.03e6. Retain the 1e-12 affine-residual assertion and add a separate 1e-12 reduced-gradient assertion.

Failure evidence

  • Develop wheel run: GCC dangling-reference error.
  • Nightly run: Linux vcpkg compiler error; Windows vcpkg weak-direction convergence failure; ARM sparse forward-error assertion; special/conda deprecated QPSolver assertions. The changes between that nightly's 4413fb8 and current develop only affected the Dense backend, not these failing paths.

Validation

GCC 14.2 Release, bundled Eigen, Boost/TBB disabled, deprecated APIs and unstable enabled:

  • Passed testActiveSetSolverOptions, testDenseQpSolver, testDualQpSolver, testLpProblem, testLpSolver, testQpInitialization, testQpProblem, testQpSolver, testSparseQpSolver, and testQPSolver via their .run targets.
  • Reproduced the original compiler error with -Werror=dangling-reference; the modified source compiles with that warning still an error.
  • Compiled the modified ActiveSetSolver and SparseQpSolver translation units and the LP ordering test with deprecated APIs disabled as well. This is compilation coverage, not a second full runtime suite.
  • The new SquareRootAffineRhsRefinement regression fails to converge with the original sparse implementation preloaded and passes with the fixed implementation.
  • Across all eight weak-affine-face variants, measured reduced-gradient residuals <=2.25e-16 and affine residuals <=3.56e-15. Forward errors were <=1.66e-8, within the derived 2.48e-7 to 2.67e-7 bounds. The former fixed 5e-9 assertion was not a portable forward-error guarantee.
  • git diff --check passed.

Native ARM, Windows, conda/vcpkg and wheel matrix verification remains pending; this is a draft, not a claim that the full matrix is already green.

Refs #2915.

@dellaert
dellaert marked this pull request as ready for review November 8, 2026 21:00
@dellaert
dellaert merged commit 0883e09 into develop Nov 8, 2026
7 checks passed
@dellaert
dellaert deleted the codex/fix-wheel-and-nightly-qp branch November 8, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant