Repository navigation
fix(input): close idle TCP and stream connections without errors - #472
Merged
Merged
Conversation
timtofan
requested review from
Joypaul11,
deniszh,
emadolsky and
grzkv
as code owners
November 3, 2026 08:37
emadolsky
approved these changes
Nov 4, 2026
deniszh
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #471
Why
An idle connection reaching its configured read deadline is an expected lifecycle event. Counting that close as a decode error makes input error metrics misleading.
Architecture
The plaintext and stream reader loops recognize timeout errors and return normally. The change is local to input error classification; protocol decoding, routing, admission, and output ownership retain their existing boundaries.
Before / after
Validation
Go 1.27.0, vendored dependencies: build, vet, serialized full tests, and golangci-lint v2 with the upstream configuration. Regression tests cover idle plaintext, idle stream input, and genuine decode failures.