Repository navigation
Remove the Jev review-screen pilot - #3892
Merged
Merged
Conversation
Over 69 reviews the screen added 9 of 354 findings on its own (5 distinct issues, all style nits), with 22% precision on standards suspects and none on spec suspects. The two rules that hit, inline-date-format and magic-number, move to lint checks (#3890). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tom2drum
added
the
tech
tom2drum
commented
Nov 13, 2026
tom2drum
left a comment
tom2drum
left a comment
Collaborator
Author
There was a problem hiding this comment.
✅ Cleared — 0 blockers, 0 majors open
blocker 0 · major 0 · nit 1 · not anchorable 0
Axes: spec (skipped — 3720 is the pilot record, not this change) · standards · correctness
— Reviewed by cursor (Grok 4.7)
|
|
||
| Send **one** message with the `general-purpose` subagents the change actually has axes for — the `jev` | ||
| axis among them. Each gets: the scope, the base ref, the touched-file list plus untracked files, the spec | ||
| Send **one** message with the `general-purpose` subagents the change actually has axes for. Each gets: the scope, the base ref, the touched-file list plus untracked files, the spec |
Collaborator
Author
There was a problem hiding this comment.
💬 cursor-F1 · nit
Removing "— the jev axis among them." left the first line of this paragraph at 180 characters, while every other paragraph in the file wraps near 110:
Send one message with the
general-purposesubagents the change actually has axes for. Each gets: the scope, the base ref, the touched-file list plus untracked files, the spec
Re-wrap the paragraph at the file's usual width.
— Reviewed by cursor (Grok 4.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Jev review-screen pilot (
tools/review-screen/) and thejevaxis it fed in thereview-changesskill.The pilot ran on 69 reviews. On its own, the screen added 9 of 354 findings. Those were 5 distinct issues, all style nits and no bugs. 22% of the standards suspects were real and 0 of 16 spec suspects were. Each false suspect still cost a subagent read. For the rules it covered, the main review found most issues and the screen didn't flag them. Two rules earned hits,
inline-date-formatandmagic-number. Both are mechanical patterns, so they move to lint checks in #3890 instead of a model-based screen.tools/review-screen/, thereview:screenscript and the@typesafe-ai/sdkdev dependency.review-changes: removes the Jev axis brief, therule:label on standards findings, thesourceslist, the origins step and thejevclose line. These existed only to measure the pilot. Thecode-revieweragent no longer returns ajevline..gitignoreand ESLint ignore entries, and the.agents/entry in the Stryker sandbox allowlist, which only the rubric spec needed.AGENTS.mdpointer, the Jev glossary row and the out-of-date mentions in other docs.The task spec
.agents/tasks/3720-jev-review-screen/spec.mdstays as the record of the pilot.Environment variables
None
Minimum API version
None
Breaking or incompatible changes
None
Additional information
None
🤖 Generated with Claude Code