Repository navigation
Allow adding the payment tx hash to token info applications under review - #3861
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tom2drum
commented
Nov 12, 2026
tom2drum
left a comment
tom2drum
left a comment
Collaborator
Author
There was a problem hiding this comment.
🛑 Blocked — 2 majors open
blocker 0 · major 2 · nit 0 · not anchorable 0
Axes: standards · correctness · jev · spec skipped (no spec)
— Reviewed by cursor (Grok 4.7)
… under review Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tom2drum
commented
Nov 12, 2026
tom2drum
left a comment
tom2drum
left a comment
Collaborator
Author
There was a problem hiding this comment.
✅ Cleared — 0 blocker, 0 major open
blocker 0 · major 0 · nit 0 · not anchorable 0
Axes: standards · correctness · jev · spec skipped (no spec)
— Reviewed by cursor (Grok 4.7)
The spec resets the module registry through withEnvs, which main's ESLint config (since the shared/isolated Vitest project split) only allows in a file named *.isolated.spec.tsx. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Assert the submit button's loading state around the payment tx PATCH, the error toast on a rejected hash, and the analytics Submit event on a new application. Suppress the ConditionalExpression mutant on the `'id' in result` guard: useFetch rejects on a non-ok response, so the guard only narrows the Success | ResourceError type. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…and run it shared Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3847
A token info application under review (
IN_PROCESS) was fully read-only, including the expedited-review payment transaction hash. Applicants who submit first and pay later had no way to add the hash. The admin service now has a dedicated endpoint for exactly that (blockscout/blockscout-admin#517), which updates only the payment tx without resetting the review.admin:token_info_application_payment_txforPATCH /token-info-submissions/{id}/payment-tx.IN_PROCESSstatus, when the instance has expedited review configured and the application has no payment tx yet, the payment hash field becomes editable and required, all other fields stay read-only, and the submit button reads "Update request" and sends the hash to the new endpoint. The existingonSubmitflow (list update, form close) is reused.Environment variables
None
Minimum API version
Admin RS microservice v1.5.3+ (ships blockscout/blockscout-admin#517; at the time of writing deployed only on staging).
Breaking or incompatible changes
None
Additional information
Decisions made during the task interview: single submit button with a changed label rather than a dedicated one; request body type inlined instead of publishing a beta
@blockscout/admin-rs-types;UPDATE_REQUIREDapplications keep the existing full-formPUTpath. No demo deploy.🤖 Generated with Claude Code