Skip to content

Simplify documentation bump plumbing and fix nested-workdir staging - #38

Merged
bcomnes merged 1 commit into
feat/major-documentation-pathsfrom
refactor/documentation-bump-cleanup
Oct 7, 2026
Merged

bcomnes merged 1 commit into
feat/major-documentation-pathsfrom
refactor/documentation-bump-cleanup

Conversation

@bcomnes

@bcomnes bcomnes commented Oct 7, 2026

Copy link
Copy Markdown
Owner
  • Stacks on Update documentation paths on major bumps with ignore-next-line support #37; targets its branch so this PR contains only the follow-up cleanup.
  • Fix tracked-file discovery in gitCommit to run from the repository root, allowing tracked files in ignored directories outside a nested WorkDir to be staged correctly. Add regression coverage for extra-only staging, bump-file staging, deduplication, and ignored untracked output.
  • Assemble the automatically updated file list once for reporting and staging, and remove redundant CLI version-file injection while keeping ExtraFiles separate from update reporting.
  • Extract rewriteDocumentationReference from the line scanner without changing reference matching or rewriting behavior.
  • Cover documentation-enabled CLI dry runs and compare complete file lists so duplicate, unexpected, or incorrectly located paths fail tests.
  • Verified with go test ./..., go test -race ./..., go vet ./..., go build ./..., and git diff --check. The staging regression failed before the fix and passes afterward.

@bcomnes
bcomnes added this pull request to stack #39 October 7, 2026 00:06
@bcomnes
bcomnes marked this pull request as ready for review October 7, 2026 00:10
@bcomnes
bcomnes requested a balanced review from Copilot October 7, 2026 00:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes are focused, consistently tested, correctly formatted, and no unresolved issues were found.

Review effort: Balanced
Findings: None

What changed in this PR

Simplifies update-file plumbing and fixes staging of tracked ignored files outside nested work directories.

Changes:

  • Discovers tracked files from the repository root.
  • Separates automatically updated files from extra staged files.
  • Expands regression coverage and extracts documentation-reference rewriting.
File Description
version_skip_docs_test.go Validates complete CLI file lists, including dry runs.
version_cli.go Removes redundant version-file staging injection.
pkg/​goversion.go Fixes staging discovery and consolidates changed-file assembly.
pkg/​git_commit_workdir_test.go Covers nested-workdir staging and ignored files.
pkg/​documentation.go Extracts single-reference rewriting logic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bcomnes
bcomnes merged commit abcbd00 into master Oct 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants