Repository navigation
Simplify documentation bump plumbing and fix nested-workdir staging - #38
Merged
bcomnes merged 1 commit intoOct 7, 2026
Merged
Conversation
bcomnes
added this pull request to stack #39
October 7, 2026 00:06
bcomnes
marked this pull request as ready for review
October 7, 2026 00:10
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are focused, consistently tested, correctly formatted, and no unresolved issues were found.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies update-file plumbing and fixes staging of tracked ignored files outside nested work directories.
Changes:
- Discovers tracked files from the repository root.
- Separates automatically updated files from extra staged files.
- Expands regression coverage and extracts documentation-reference rewriting.
| File | Description |
|---|---|
version_skip_docs_test.go |
Validates complete CLI file lists, including dry runs. |
version_cli.go |
Removes redundant version-file staging injection. |
pkg/goversion.go |
Fixes staging discovery and consolidates changed-file assembly. |
pkg/git_commit_workdir_test.go |
Covers nested-workdir staging and ignored files. |
pkg/documentation.go |
Extracts single-reference rewriting logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitCommitto run from the repository root, allowing tracked files in ignored directories outside a nestedWorkDirto be staged correctly. Add regression coverage for extra-only staging, bump-file staging, deduplication, and ignored untracked output.ExtraFilesseparate from update reporting.rewriteDocumentationReferencefrom the line scanner without changing reference matching or rewriting behavior.go test ./...,go test -race ./...,go vet ./...,go build ./..., andgit diff --check. The staging regression failed before the fix and passes afterward.