Repository navigation
Feat/pr 243 - #155
Merged
Merged
Feat/pr 243#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Upstream: bbc/tams#243 (fixes bbc/tams#242)
Description of changes:
Brings
maininto line with bbc/tamsmainat16c1db0. The only API change since the 8.2 tag is bbc/tams#243, which adds dedicated endpoints for the Flowstatusproperty. Until nowstatuscould only be changed by PUTting the whole Flow.New endpoints:
/flows/{flowId}/statusHEAD200,404GET200(JSON string, e.g."closed_complete"),404PUT204,400(not a validflow-statusvalue),403(Flow is read-only),404DELETE204,403(Flow is read-only),404Writes publish a
flows/updatedevent, as the other Flow property endpoints do.Changes
functions/api_flows/app.py: HEAD/GET/PUT/DELETE handlers, following thelabel/max_bit_ratepattern. The PUT body is validated against theFlowstatusenum.template.yaml: API Gateway events for the 4 routes.functions/lambda_authorizer/oauth_scopes.json:readfor HEAD/GET,writefor PUT/DELETE.api/build/openapi.yaml: regenerated from the upstream spec.api/TAMS_UPSTREAM_SHA: moved from34fb31b(8.2) to16c1db0.Tests
Not included
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.