Repository navigation
chore(proto): regenerate stubs after a protovalidate dep bump - #823
Closed
lakhansamani wants to merge 1 commit into
Closed
lakhansamani wants to merge 1 commit into
lakhansamani wants to merge 1 commit into
Conversation
buf dep update picks up a newer buf.build/bufbuild/protovalidate, which moved its documentation URLs from buf.build/docs/protovalidate/... to protovalidate.com/..., changing seven doc comments in the generated TS. No API, field or wire change -- comments and the buf.lock digest only. Latent on main: buf.yml runs on changes to proto/, gen/ or the Makefile, so the staleness gate stayed quiet until a PR touched one of those and then failed for a reason unrelated to its own diff.
Contributor
Author
|
Superseded by #824, which carries this change unmodified alongside the other three commits in one PR — no merge-order dependency between them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks CI. Found while #821 went red on
Lint & breakingfor a reason that had nothing to do with its own diff.buf dep updateresolves a newerbuf.build/bufbuild/protovalidate, which moved its documentation URLs:Seven doc comments in
gen/ts/buf/validate/validate_pb.ts, plus theproto/buf.lockdigest. No API, field or wire change.This was latent on
main:buf.ymltriggers on changes toproto/**,gen/**or theMakefile, so the staleness gate stayed quiet until a PR touched one of those — #821 edits theMakefileto add a test target — and then failed pointing at the wrong change.Verification
make proto-check,make proto-check-clients,make proto-lint: all pass.make proto-genandmake proto-gen-clientsafter committing leaves the tree clean, so this is not a moving target.go build ./...,go vet ./...: clean.