Skip to content

Add a shared pull request report publisher - #29603

Merged
zanieb merged 18 commits into
mainfrom
zb/automation-report-index
Oct 22, 2026
Merged

zanieb merged 18 commits into
mainfrom
zb/automation-report-index

Conversation

@zanieb

@zanieb zanieb commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Add publish-pull-request-report.yml as a shared publisher for automation reports, using STS for GitHub writes and the KV actions for comment IDs. Store IDs in pull-request scope so later runs can update the same report.

Look up each stored ID directly and verify the bot, PR, marker, and run metadata. When a report is published, missing or expired keys create a new comment without scanning existing comments; deleted comments are replaced. Malformed IDs, IDs belonging to another comment, and KV errors fail the job. The publisher verifies the source run and current PR head before writing; report workflows enable it separately.

@zanieb zanieb added the ci Related to internal CI tooling label Oct 21, 2026
@zanieb zanieb changed the title Reserve an early index for automation reports Add cached lookup for pull request report comments Oct 22, 2026
@zanieb zanieb changed the title Add cached lookup for pull request report comments Add a shared pull request report publisher Oct 22, 2026
Comment thread scripts/pull_request_comments.py Resolved
@zanieb
zanieb changed the base branch from main to zb/automation-service-policies October 22, 2026 04:54
Base automatically changed from zb/automation-service-policies to main October 22, 2026 05:15
Comment thread scripts/publish_pr_report.py Resolved
@zanieb
zanieb added this pull request to stack #29618 October 22, 2026 05:28
@zanieb
zanieb marked this pull request as ready for review October 22, 2026 05:30
@zanieb
zanieb force-pushed the zb/automation-report-index branch from 0de4fb7 to 617b469 Compare October 22, 2026 05:37
@zanieb
zanieb enabled stacked auto-merge (squash) October 22, 2026 05:42
stacked auto-merge was automatically disabled October 22, 2026 05:43

Auto-merge was disabled for another pull request in the stack

@zanieb
zanieb enabled stacked auto-merge (squash) October 22, 2026 05:45
stacked auto-merge was automatically disabled October 22, 2026 05:49

Auto-merge was disabled for another pull request in the stack

@zanieb
zanieb merged commit ad83e52 into main Oct 22, 2026
53 checks passed
@zanieb
zanieb deleted the zb/automation-report-index branch October 22, 2026 05:49
zanieb added a commit that referenced this pull request Oct 22, 2026
Ruff ecosystem report comments currently depend on `astral-sh-bot`.
Publish `ecosystem-result` after the CI ecosystem job using the shared
STS publisher in #29603. Comment IDs come exclusively from the key-value
store.

This handles same-repository pull requests, including runs that upload a
report before failing.

---------

Co-authored-by: zaniebot <242828183+zaniebot@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
automations — 617b469c Deployed Oct 22, 2026 by zanieb via security-review / security review #92803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants