Skip to content

Update installation instructions and enhance GitHub Actions workflow - #210

Merged
Rusydy merged 3 commits into
asdf-community:masterfrom
Rusydy:issues/202
Nov 7, 2026
Merged

Rusydy merged 3 commits into
asdf-community:masterfrom
Rusydy:issues/202

Conversation

@Rusydy

@Rusydy Rusydy commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

this is for #202

Summary by cubic

Updates the README installation instructions and expands CI coverage so the plugin's documented build works on more distributions.

  • Reworks the Ubuntu and macOS dependency lists to match what's actually required and adds Arch Linux and Fedora 44 instructions.
  • Documents optional extensions (GMP, sodium, PostgreSQL, FreeType, tidy) instead of listing them as mandatory.
  • Adds Arch and Fedora container jobs to CI that build PHP and verify loaded extensions, with a 45-minute timeout on the Arch job.
  • Removes the paths-ignore on markdown files so documentation changes trigger a workflow run.
  • CI now verifies intl, mbstring, zip, gd, xsl, bz2, pdo_sqlite, and tidy in addition to openssl and curl, replacing the old sodium and gmp checks.

Written for commit 7cbf2eb. Summary will update on new commits.

View guided diff

@Rusydy
Rusydy requested a review from a team as a code owner November 7, 2026 15:14

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/workflow.yml">

<violation number="1" location=".github/workflows/workflow.yml:18">
P2: Removing `gcc-9 g++-9` from `UBUNTU_DEPS` silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore `gcc-9 g++-9` if those builds should keep using it; otherwise update that comment and call out the change.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

UBUNTU_DEPS: "autoconf bison build-essential curl gettext git python3 libgd-dev libbz2-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libgmp-dev libreadline-dev libsodium-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev autotools-dev m4 libtool-bin"
MACOS_DEPS: "autoconf automake bison freetype gd gettext icu4c krb5 gmp libedit libiconv libjpeg libpng libsodium libxml2 libzip openssl@3 pkg-config re2c zlib bzip2 python3"
# Build dependencies from the README. Optional GMP and sodium are not tested here.
UBUNTU_DEPS: "autoconf bison build-essential curl git python3 pkg-config re2c ca-certificates libbz2-dev libcurl4-openssl-dev libicu-dev libjpeg-dev libpng-dev libonig-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev zlib1g-dev libxslt1-dev libtidy-dev"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing gcc-9 g++-9 from UBUNTU_DEPS silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore gcc-9 g++-9 if those builds should keep using it; otherwise update that comment and call out the change.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/workflow.yml, line 18:

<comment>Removing `gcc-9 g++-9` from `UBUNTU_DEPS` silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore `gcc-9 g++-9` if those builds should keep using it; otherwise update that comment and call out the change.</comment>

<file context>
@@ -6,21 +6,17 @@ on:
-  UBUNTU_DEPS: "autoconf bison build-essential curl gettext git python3 libgd-dev libbz2-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libgmp-dev libreadline-dev libsodium-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev autotools-dev m4 libtool-bin"
-  MACOS_DEPS: "autoconf automake bison freetype gd gettext icu4c krb5 gmp libedit libiconv libjpeg libpng libsodium libxml2 libzip openssl@3 pkg-config re2c zlib bzip2 python3"
+  # Build dependencies from the README. Optional GMP and sodium are not tested here.
+  UBUNTU_DEPS: "autoconf bison build-essential curl git python3 pkg-config re2c ca-certificates libbz2-dev libcurl4-openssl-dev libicu-dev libjpeg-dev libpng-dev libonig-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev zlib1g-dev libxslt1-dev libtidy-dev"
+  MACOS_DEPS: "autoconf bison bzip2 icu4c libedit libiconv libjpeg libpng libxml2 libxslt libzip openssl@3 pkg-config re2c zlib python3"
 
</file context>

Comment thread README.md Resolved
Comment thread .github/workflows/workflow.yml Resolved
@Rusydy
Rusydy merged commit 8c51982 into asdf-community:master Nov 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant