Repository navigation
Update installation instructions and enhance GitHub Actions workflow - #210
Merged
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/workflow.yml">
<violation number="1" location=".github/workflows/workflow.yml:18">
P2: Removing `gcc-9 g++-9` from `UBUNTU_DEPS` silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore `gcc-9 g++-9` if those builds should keep using it; otherwise update that comment and call out the change.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| UBUNTU_DEPS: "autoconf bison build-essential curl gettext git python3 libgd-dev libbz2-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libgmp-dev libreadline-dev libsodium-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev autotools-dev m4 libtool-bin" | ||
| MACOS_DEPS: "autoconf automake bison freetype gd gettext icu4c krb5 gmp libedit libiconv libjpeg libpng libsodium libxml2 libzip openssl@3 pkg-config re2c zlib bzip2 python3" | ||
| # Build dependencies from the README. Optional GMP and sodium are not tested here. | ||
| UBUNTU_DEPS: "autoconf bison build-essential curl git python3 pkg-config re2c ca-certificates libbz2-dev libcurl4-openssl-dev libicu-dev libjpeg-dev libpng-dev libonig-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev zlib1g-dev libxslt1-dev libtidy-dev" |
There was a problem hiding this comment.
P2: Removing gcc-9 g++-9 from UBUNTU_DEPS silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore gcc-9 g++-9 if those builds should keep using it; otherwise update that comment and call out the change.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/workflow.yml, line 18:
<comment>Removing `gcc-9 g++-9` from `UBUNTU_DEPS` silently switches the legacy Ubuntu PHP builds from gcc-9 to the default gcc. The matrix comment still says gcc-9 is used for legacy builds. Restore `gcc-9 g++-9` if those builds should keep using it; otherwise update that comment and call out the change.</comment>
<file context>
@@ -6,21 +6,17 @@ on:
- UBUNTU_DEPS: "autoconf bison build-essential curl gettext git python3 libgd-dev libbz2-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libgmp-dev libreadline-dev libsodium-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev autotools-dev m4 libtool-bin"
- MACOS_DEPS: "autoconf automake bison freetype gd gettext icu4c krb5 gmp libedit libiconv libjpeg libpng libsodium libxml2 libzip openssl@3 pkg-config re2c zlib bzip2 python3"
+ # Build dependencies from the README. Optional GMP and sodium are not tested here.
+ UBUNTU_DEPS: "autoconf bison build-essential curl git python3 pkg-config re2c ca-certificates libbz2-dev libcurl4-openssl-dev libicu-dev libjpeg-dev libpng-dev libonig-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev zlib1g-dev libxslt1-dev libtidy-dev"
+ MACOS_DEPS: "autoconf bison bzip2 icu4c libedit libiconv libjpeg libpng libxml2 libxslt libzip openssl@3 pkg-config re2c zlib python3"
</file context>
…ency clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is for #202
Summary by cubic
Updates the README installation instructions and expands CI coverage so the plugin's documented build works on more distributions.
Written for commit 7cbf2eb. Summary will update on new commits.