Repository navigation
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/workflow.yml">
<violation number="1" location=".github/workflows/workflow.yml:53">
P1: `fedora-44` is not a GitHub-hosted runner label, so this matrix job will not match any runner and will stay queued or fail. The Linux install step also calls `apt-get` with the Ubuntu package list, which Fedora does not provide. Drop this entry, or add a container-based Fedora job that installs dependencies with `dnf`.</violation>
</file>
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
| version: 8.5.12 | ||
| is_legacy: true | ||
| # Latest | ||
| - os: fedora-44 |
There was a problem hiding this comment.
P1: fedora-44 is not a GitHub-hosted runner label, so this matrix job will not match any runner and will stay queued or fail. The Linux install step also calls apt-get with the Ubuntu package list, which Fedora does not provide. Drop this entry, or add a container-based Fedora job that installs dependencies with dnf.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/workflow.yml, line 53:
<comment>`fedora-44` is not a GitHub-hosted runner label, so this matrix job will not match any runner and will stay queued or fail. The Linux install step also calls `apt-get` with the Ubuntu package list, which Fedora does not provide. Drop this entry, or add a container-based Fedora job that installs dependencies with `dnf`.</comment>
<file context>
@@ -50,6 +50,9 @@ jobs:
version: 8.5.12
is_legacy: true
# Latest
+ - os: fedora-44
+ version: latest
+ is_legacy: false
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds Fedora 44 with the latest PHP version to the CI test matrix so builds are verified on the new distribution alongside the existing entries.
Written for commit 21ef58f. Summary will update on new commits.