Repository navigation
fix(native): recover Android wallet startup and privacy controls #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c910677
fix(native): recover Android wallet startup and privacy controls
Kukks 71250b6
fix(native): fence connection and recovery races
Kukks bee7585
fix(native): bound direct connections and close recovery fences
Kukks 5a8f352
fix(wallet): preserve native resume and complete receive flows
Kukks a3d6fb8
fix(receive): keep pending addresses unavailable with amounts
Kukks 6e0977c
fix(wallet): bound recovery waits and normalize LNURL links
Kukks 6c75c94
docs(native): clarify connection choices and foreground resume
Kukks 5ae51eb
fix(native): close receive and suspension review gaps
Kukks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import {useEffect,useRef} from 'react'; | ||
| import './native-connection-warning.css'; | ||
|
|
||
| export default function NativeConnectionWarning({onCancel,onConfirm}:{onCancel:()=>void;onConfirm:()=>void}){ | ||
| const dialog=useRef<HTMLDialogElement>(null); | ||
| useEffect(()=>{const node=dialog.current;if(node&&!node.open)node.showModal();return()=>node?.close();},[]); | ||
| return <dialog ref={dialog} className="native-connection-warning" aria-labelledby="direct-connection-title" aria-describedby="direct-connection-detail" onCancel={event=>{event.preventDefault();onCancel();}}> | ||
| <span className="native-connection-warning-eyebrow">Network privacy</span> | ||
| <h2 id="direct-connection-title">Turn off Tor?</h2> | ||
| <p id="direct-connection-detail">Wallet services will see your IP address. Your network and DNS provider can see which services you contact. Separate Tor circuits will no longer protect unrelated wallet items.</p> | ||
| <p>Your wallet will reconnect directly for this app session. Tor starts again the next time you launch Shielded.</p> | ||
| <div><button type="button" autoFocus onClick={onCancel}>Keep Tor on</button><button type="button" className="native-connection-confirm" onClick={onConfirm}>Turn off Tor and reconnect</button></div> | ||
| </dialog>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.