Repository navigation
fix(query-redis-labs): support configurable REDIS_PORT - #493
Open
sundeep8967 wants to merge 1 commit into
Open
sundeep8967 wants to merge 1 commit into
sundeep8967 wants to merge 1 commit into
Conversation
Previously the Redis socket connection hardcoded port 14714. Redis Cloud assigns dynamic ports per created database, preventing instances from connecting when deployed outside port 14714. Allow configuring REDIS_PORT via environment variable with fallback to 14714 for backward compatibility. Document the variable in README. Fixes appwrite#490 Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
🟢 Tier S · Ready to merge
The Redis Labs function now reads an optional
Note @sundeep8967 does not have write access to this repository, so Hansi does not approve automatically. A maintainer can review and approve. 📂 Walkthrough · 2
Reviewed |
![appwrite[bot]](https://avatars.githubusercontent.com/in/325556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously
node/query-redis-labs/src/redis.jshardcoded port 14714 for the socket connection to Redis Cloud. Because Redis Cloud allocates unique ports per deployed database instance, functions created from this template fail to connect unless the user happens to have port 14714 assigned.Solution
REDIS_PORTfromprocess.envingetClient(), parsing it to an integer.14714to preserve backward compatibility.REDIS_PORTinnode/query-redis-labs/README.md.Fixes #490