[TorstenDittmann]

Requested by Torsten · project thread

Why

filterFiles excluded every deleted file, so a pull request that only deletes files ended with no included files and runReview skipped it as "No reviewable changes". Such PRs (e.g. the Dependabot-config removals) never got a review, and so never an approval. hansi.codes has the same behaviour.

What changes

• Filters before content (filters.ts): path filters and default ignores are checked first, so deleted now marks only a removal the review would otherwise cover. Deleting a lockfile or a filtered path still reads as ignored by default / path filter and still skips.
• Deletion-only PRs are reviewed (review.ts): when nothing is included but reviewable files were removed, the review runs. The removed lines go into the prompt (within the diff budget), and the prompt tells the reviewer to grep for code, config, workflows, scripts and docs that still depend on what was deleted.
• Findings still gate approval: removed lines cannot carry an inline comment, so findings in a deletion-only review are placement misses, listed in the summary as before. If those would have stopped approval under decideVerdict (blocking severity or a bug finding), approval is withheld with a reason, so Hansi never approves a deletion it found a problem with.

Tests

Added in core.test.ts: filter reasons for removals, a deletion-only review that approves with the removed lines in the prompt, and one that withholds approval for an unplaceable bug finding. bun run lint, bun run check and bun run test (364 pass) are green.

---

Generated by Claude Code

[hansi-codes]

🟢 Tier S · Ready to merge

This PR lets reviews proceed when a pull request only removes reviewable files: filtering happens before deleted files are classified, and the removed diff is included in the reviewer prompt within the diff budget. It adds guidance to look for remaining references, makes qualifying unplaceable findings and truncated deletion diffs withhold approval, and applies path-specific instructions to removed files. Tests cover filtering, deletion-only approvals, unplaceable findings, path instructions, and diff-budget truncation.

Latest changes: The newest commits apply path instructions to removed files and ensure unplaced findings below minSeverity do not withhold approval, while a deletion whose diff does not fit the prompt still cannot be approved.

Verdict	New comments	Fixed	Still open
✅ Approved	0	0	0

📂 Walkthrough · 4

File	Change
packages/engine/src/core.test.ts	Adds tests for deletion-only reviews, filtering, approval gating, path instructions, and removed diffs that exceed the prompt budget.
packages/engine/src/filters.ts	Applies path and default filters before classifying deleted files.
packages/engine/src/prompts.ts	Adds reviewer instructions for checking what deleted files may still be referenced.
packages/engine/src/review.ts	Includes reviewable deleted-file diffs in deletion-only reviews, applies path instructions to shown removals, and gates approval on truncation and qualifying unplaceable findings.

---

_{Reviewed the commits since e9f0595 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.}

[hansi-codes]

🟡 Tier B · 1 blocking finding to address. Summary

[hansi-codes]

🟡 Tier B · 1 blocking finding to address. Summary

[hansi-codes]

🟢 Tier S · Looks good to merge. Summary