[ChiragAgg5k]

What

Renovate's Astro 7.3.3 security update (#18) fails Type check: test/cache-provider.test.js(31,28): Property 'logger' is missing. Main is green on Astro 7.2; the failure comes from the upgrade itself.

Why

Astro 7.3.3 makes logger a required member of the context passed to a cache provider's onRequest. The test helper builds that context as an object literal without it. The provider never reads logger, so only the type changed.

Fix

Assert the helper's context to Parameters<typeof instance.onRequest>[0]. That keeps the test valid against both Astro 7.2 (current lock) and 7.3.3, so this can merge first and #18 passes after a rebase.

Verified locally: npm run typecheck and npm test (67 pass) on the current lock and with astro@7.3.3 installed; biome format and biome lint are clean. Without the change, astro@7.3.3 reproduces the TS2345 error.

Opened from a fork because I don't have push access to this repository.

[hansi-codes]

🟢 Tier S · Ready to merge

The change is limited to a type assertion in a test helper and introduces no runtime behavior change.

The cache-provider test helper now creates the request context separately and casts it to the parameter type of onRequest. This allows the test context to type-check against Astro versions with differing context requirements.

Verdict	New comments	Fixed	Still open
✅ Approved	0	0	0

📂 Walkthrough · 1

File	Change
test/cache-provider.test.js	Builds the helper context and types it from the provider's onRequest parameter.

---

_{Reviewed 8eb967d · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.}

[hansi-codes]

🟢 Tier S · Looks good to merge. Summary