Repository navigation
SOLR-18602: Follow aliases in DELETEREPLICA by count - #5259
Open
sarkaramrit1993 wants to merge 1 commit into
Open
sarkaramrit1993 wants to merge 1 commit into
sarkaramrit1993 wants to merge 1 commit into
Conversation
DELETEREPLICA with count read the collection name as-is and ignored followAliases, so an alias failed with Could not find collection. Resolve the alias the same way the replica-name path does.
Contributor
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SOLR-18602:
DELETEREPLICAwithcountignoresfollowAliases, socollection=myAlias&count=1&followAliases=truefails withCould not find collection : myAlias.DeleteReplicaCmd.callroutes count requests todeleteReplicaBasedOnCountbefore it readsfollowAliases. Deleting by replica name already resolves the alias.Solution
Resolve the alias in
deleteReplicaBasedOnCountthe same way the replica-name path does.Tests
DeleteReplicaTest.deleteReplicaByCountFollowsAliasesdeletes by count through an alias, for one shard and across all shards. It fails on main and passes with the fix.DeleteReplicaTest,TestCollectionAPIandAliasIntegrationTestpass.Related to SOLR-18589 (#5255).